Re: [PATCH] mptctl.c memory leak on failure

Arnaldo Carvalho de Melo (acme@conectiva.com.br)
Sun, 7 Jan 2001 14:09:17 -0200


Em Sun, Jan 07, 2001 at 01:37:15PM +0000, Alan Cox escreveu:
> > kmalloc and the comment: the buffer is used for DMA but the kmalloc doesn't
> > has GFP_DMA, maybe I'm missing something here, its about time for me to
>
> It should be kmalloc (or 2.4 wise pci_alloc_* I guess eventually). Its driven
> by 32bit busmaster DMA. Its non ISA so it doesnt need GFP_DMA

yap, I should have have some sleep before suggesting that 8) Now back
looking at the other files, I've found another not so grave potential
memory leak, patch in some minutes

- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/