Re: ramfs problem... (unlink of sparse file in "D" state)

Alexander Viro (viro@math.psu.edu)
Mon, 8 Jan 2001 15:12:40 -0500 (EST)


On Mon, 8 Jan 2001, Andreas Dilger wrote:

> Actually, this is wrong. The ext2 inode limit is 2^32 512-byte sectors,
> not 2^32 blocksize blocks. Yes this is a wart and Ted wants to fix it, as

??? Where? Oh, wait... ->i_blocks? I'ld rather refuse to grow past 2^32 -
sparse files can legitimately have large offsets and very low ->i_blocks.
But yes, we need to check for overflows. BTW, 2^32-1 is not good enough -
indirect blocks also contribute, so limiting ->i_size by 2Tb is not
guaranteed to keep ->i_blocks low.

IMO it's bogus - so far we are protected by inability to allocate that
much and once we are past that limit we should rather refuse to do
allocation than refuse to get large sparse files.

Or was it about something entirely different? I don't see other limiting
factors that would give 2Tb boundary for ->i_size, but ICBW.

Al, going down...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/