Re: [PATCH] advansys.c: include missing restore_flags, etc

[Pauline Middelink]

On Tue, 09 Jan 2001 around 00:14:43 -0200, Arnaldo Carvalho de Melo wrote:
> Hi,
> 
> 	Please consider applying, comments in the patch.
> 
> - Arnaldo
> 
> 
> --- linux-2.4.0-ac4/drivers/scsi/advansys.c	Mon Jan  8 20:39:28 2001
> +++ linux-2.4.0-ac4.acme/drivers/scsi/advansys.c	Tue Jan  9 00:12:03 2001

> -STATIC int
> +STATIC unsigned long
>  DvcEnterCritical(void)
>  {
> -    int    flags;
> +    unsigned long flags;
>  
>      save_flags(flags);
>      cli();
> @@ -9965,7 +9972,7 @@
>  }

Err, according tho wise ppl on this list, this does not work on
MIPSes. The flags thing must stay in the same stackframe.

(I know, not your fault, but since you are patching the driver...)

>  STATIC void
> -DvcLeaveCritical(int flags)
> +DvcLeaveCritical(unsigned long flags)
>  {
>      restore_flags(flags);
>  }

Item.

    Met vriendelijke groet,
        Pauline Middelink
-- 
GPG Key fingerprint = 2D5B 87A7 DDA6 0378 5DEA  BD3B 9A50 B416 E2D0 C3C2
For more details look at my website http://www.polyware.nl/~middelink