Re: patch for 2.4.0 disable printk and panic messages, third try

[Abramo Bagnara]

Stefani Seibold wrote:
> 
> Hi guys,
> 
> this is now the third try to release my patch for disabling all kernel
> messages. It is usefull on deep embedded systems with no human interactions
> and for rescue discs where the diskspace is always to less.
> 
> This patch has now the following features:
> 
> The macro printk throws away all parameters and calls now a funciton "inline
> int printk_inline(void)" which always return 0 integer. So it should be now
> compatibel to the original printk funciton.
> 

Then I suppose that you've checked that never in kernel printk arguments
have side effects, don't you ;-)

printk("%d", p());
printk("%d", a++);
etc.

You're changing semantics of a well known function and also if you don't
broke anything now, what grants this for the future?

You need also a big warning in printk documentation: "Note that
arguments may to be not evaluated" and hope everybody note it.

I'd prefer to rely on modern compiler smartness.

-- 
Abramo Bagnara                       mailto:[e-mail]

Opera Unica                          Phone: [phone]
Via Emilia Interna, 140
48014 Castel Bolognese (RA) - Italy

ALSA project is            http://www.alsa-project.org
sponsored by SuSE Linux    http://www.suse.com

It sounds good!