Re: NFS stop/start problems (related to datagram shutdown bug?)

Trond Myklebust (trond.myklebust@fys.uio.no)
Tue, 6 Feb 2001 10:27:16 +0100 (CET)


>>>>> " " == Neil Brown <neilb@cse.unsw.edu.au> writes:

> The attached patch might fix it, so if you are having
> reproducable problems, it might be worth applying this patch.

> Trond: any comments?

> +
> + spin_lock_bh(&serv->sv_lock);
> if (!--(svsk->sk_inuse) && svsk->sk_dead) {
> + spin_unlock_bh(&serv->sv_lock);
> dprintk("svc: releasing dead socket\n");
> sock_release(svsk->sk_sock);
> kfree(svsk);
> }
> + else
> + spin_unlock_bh(&serv->sv_lock);
> }

Looks correct, but there's a similar problem in svc_delete_socket()
(see the setting of sk_dead, and subsequent test for sk_inuse).

Cheers,
Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/