2.4.0 pdev_enable_device() call in setup-bus.c

Grant Grundler (grundler@cup.hp.com)
Wed, 7 Feb 2001 11:50:52 -0800 (PST)


Hi Ivan,
Can you explain why pci_assign_unassigned_resources()
calls pdev_enable_device() for every PCI device instead
of having each PCI *driver* call pci_enable_device()
as part of driver initialization?

I'm thinking I missed something that a comment in the code
should have explained.

After having written the bulk of PCI support for parisc port,
I was clearly under the impression the PCI driver was
supposed to call pci_enable_device(). IMHO, it's a *bad* idea
to enable a device when it's driver might not be present.

thanks,
grant

Code from drivers/pci/setup-bus.c:
void __init
pci_assign_unassigned_resources(void)
{
...
pci_for_each_dev(dev) {
pdev_enable_device(dev);
}
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/