Re: Bug in tcp_time_to_recover

kuznet@ms2.inr.ac.ru
Wed, 7 Feb 2001 23:13:29 +0300 (MSK)


Hello!

> /* Not-A-Trick#2 : Classic rule... */
> if (tcp_fackets_out(tp) > tp->reordering)
> ^^^^^^^^^
> return 1;
...
> Shouldn't it be a >= instead of > ?

No. fackets_out is equivalent of Reno dupacks+1.

F.e. look at the most common case, where FACK is equivalent to Reno:

| hole | sack1 | sack2 | sack3

fackets_out = 4
but
dupacks = 3

Alexey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/