Re: 2.4.2-pre3 compile error in 6pack.c

[David Weinehall]

On Sun, Feb 11, 2001 at 02:59:13PM -0500, Jeff Garzik wrote:
> Alan Cox wrote:
> > 
> > > 2.4.2-pre3 doesn't compile with 6pack as a module; I had to disable it;
> > > now it compiles (and so far, works fine).
> > 
> > It has a slight dependancy on -ac right now.
> > 
> > KMALLOC_MAXSIZE is the alloc size limit - 131072. It checks this as kmalloc
> > now panics if called with an oversize request
> 
> Would it be costly/reasonable to have kmalloc -not- panic if given a
> too-large size?  Principle of Least Surprises says it should return NULL
> at the very least.

It's on purpose; to find the erroneous drivers.

/David Weinehall
  _                                                                 _
 // David Weinehall <[e-mail]> /> Northern lights wander      \\
//  Project MCA Linux hacker        //  Dance across the winter sky //
\>  http://www.acc.umu.se/~tao/    </   Full colour fire           </