2.4.1-ac breaks parport_pc when CONFIG_PCI=n

Mikael Pettersson (mikpe@csd.uu.se)
Fri, 16 Feb 2001 01:14:01 +0100 (MET)


2.4.1-ac breaks parport_pc in PCI-less configs.
Attempting to 'make vmlinux' in 2.4.1-ac14 with

# CONFIG_MODULES is not set
# CONFIG_PCI is not set
CONFIG_PARPORT=y
CONFIG_PARPORT_PC=y

results in

drivers/parport/driver.o: In function `parport_pc_init_superio':
drivers/parport/driver.o(.text.init+0x1311): undefined reference to `pci_devices'
drivers/parport/driver.o(.text.init+0x1316): undefined reference to `pci_devices'
drivers/parport/driver.o(.text.init+0x1323): undefined reference to `pci_devices'
make: *** [vmlinux] Error 1

parport_pc_init_superio() contains a pci_for_each_dev loop. This macro
references pci_devices which doesn't exist when CONFIG_PCI=n.
2.4.1 vanilla has a #ifdef CONFIG_PCI/#endif pair around the offending
code, but 2.4.1-ac removes the #ifdef leading to the error above.

Either the #ifdef needs to be put back in, or pci_for_each_dev should
have a dummy #define in <linux/pci.h> for !CONFIG_PCI, like many of the
other pci functions.

/Mikael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/