Re: [PATCH] tiny MM performance and typo patches for 2.4.2

[David S. Miller]

Ulrich Kunitz writes:
 > patch-uk6	In 2.4.x _page_hashfn divides struct address_space pointer
 > 		with a parameter derived from the size of struct
 > 		inode. Deriving this parameter from the size of struct
 > 		address_space makes more sense -- at least for me.

The address_space is %99 of the time (unless swapping, and in that
case the address is constant :-)) inside of an inode struct so this
change actually makes the hash worse.  I looked at this one time
myself...

Later,
David S. Miller
[e-mail]