Re: [patch] Does this correct a bug in ibmcam.c?

[Alan Cox]

> +			int chan;
>  
> -			if (copy_from_user(&v, arg, sizeof(v)))
> -				return -EFAULT;
> -			if ((v < 0) || (v >= 3)) /* 3 grades of lighting conditions */
> -				return -EINVAL;
> -			if (v != ibmcam->vchan.channel) {
> -				ibmcam->vchan.channel = v;
> +			chan = (int)arg;
> +		
> +			if ((chan < 0) || (chan >= 3)) /* 3 grades of lighting conditions */ 
> +			 	return -EINVAL;			
> +	
> +			if (chan != ibmcam->vchan.channel) { 	
> +				ibmcam->vchan.channel = chan; 			
>  				usb_ibmcam_change_lighting_conditions(ibmcam);
> -			}
> + 			}
>  			return 0;
>  		}

This change is wrong. I think you are calling the ioctl wrongly