Re: [BUG] vmalloc_area_pages() in 2.4.2-ac25

[Andrew Morton]

Tachino Nobuhiro wrote:
> 
>   vmalloc_area_pages() in 2.4.2-ac25 seems to be broken. It calls
> spin_lock(&init_mm.page_table_lock) twice and causes system hang.
> 

Yes, it would.  Delete the innermost lock and unlock.

--- linux-2.4.2-ac25/mm/vmalloc.c	Mon Mar 26 21:38:38 2001
+++ ac/mm/vmalloc.c	Mon Mar 26 21:52:05 2001
@@ -152,9 +152,7 @@
 	do {
 		pmd_t *pmd;
 		
-		spin_lock(&init_mm.page_table_lock);	/* pmd_alloc requires this */
 		pmd = pmd_alloc(&init_mm, dir, address);
-		spin_unlock(&init_mm.page_table_lock);
 		ret = -ENOMEM;
 		if (!pmd)
 			break;