Re: CML1 cleanup patch, take 3

[Eric S. Raymond]

Philip Blundell <[e-mail]>:
> >    if [ "$CONFIG_PRINTER" != "n" ]; then
> >-      bool '    Support IEEE1284 status readback' CONFIG_PRINTER_READBACK
> >+      bool '    Support IEEE1284 status readback' CONFIG_PARPORT_1284
> >    fi
> 
> This isn't really right.  Although it's true that
> CONFIG_PARPORT_1284 enables the stuff that used to be controlled by
> CONFIG_PRINTER_READBACK, the two aren't synonymous.  The m68k port
> ought to just use drivers/parport/Config.in like everybody else.

Yes, I figured this out.  The CML2 rules file section for m68k already uses
the normal, architecture-independent parallel-port subtree (some of the
individual options in it are suppressed on certain platforms).

At this point, the only place CONFIG_PRINTER_READBACK actually occurs
seems to be in doc files.  So selecting it is a no-op, but one that
obviously means the user wanted the IEEE1284 support.  Even given the
two aren't equivalent, I don't see a better way to handle this than the
above.  Let's be kind to our 2.4.x users.

-- 
		<a href="http://www.tuxedo.org/~esr/">Eric S. Raymond</a>

The right of self-defense is the first law of nature: in most
governments it has been the study of rulers to confine this right
within the narrowest limits possible.  Wherever standing armies
are kept up, and when the right of the people to keep and bear
arms is, under any color or pretext whatsoever, prohibited,
liberty, if not already annihilated, is on the brink of
destruction." 
	-- Henry St. George Tucker (in Blackstone's Commentaries)