Re: generic_osync_inode() broken?

[Linus Torvalds]

On Thu, 12 Apr 2001, Marcelo Tosatti wrote:
>
> Comments?
>
> --- fs/inode.c~	Thu Mar 22 16:04:13 2001
> +++ fs/inode.c	Thu Apr 12 15:18:22 2001
> @@ -347,6 +347,11 @@
>  #endif
>
>  	spin_lock(&inode_lock);
> +	while (inode->i_state & I_LOCK) {
> +		spin_unlock(&inode_lock);
> +		__wait_on_inode(inode);
> +		spin_lock(&inode_lock);
> +	}
>  	if (!(inode->i_state & I_DIRTY))
>  		goto out;
>  	if (datasync && !(inode->i_state & I_DIRTY_DATASYNC))

Ehh.

Why not just lock the inode around the thing?

The above looks rather ugly.

		Linus