Re: 8139too: defunct threads

[Manfred Spraul]

This is a multi-part message in MIME format.

------=_NextPart_000_0021_01C0C4FC.049C51D0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit

>> Ah. Of course. All (or most) kernel initialisation is
>> done by PID 1. Search for "kernel_thread" in init/main.c
>>
>> So it seems that in your setup, process 1 is not reaping
>> children, which is why this hasn't been reported before.
>> Is there something unusual about your setup?

> I found the difference which causes this. If I build my kernel with
> IP_PNP (IP: kernel level autoconfiguration) support I get a defunt
> thread for each 8139too device. If I don't build with IP_PNP
> support I don't get any, defunct ethernet threads.

Does init(8) reap children that died before it was spawned? I assume
that the defunct tasks were there _before_ init was spawned.

Perhaps init() [in linux/init/main.c] should reap all defunct tasks
before the execve("/sbin/init").

I've attached an untested patch, could you try it?

--
    Manfred

------=_NextPart_000_0021_01C0C4FC.049C51D0
Content-Type: application/octet-stream;
	name="patch-main.dat"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="patch-main.dat"

--- main.c	Fri Mar 30 15:42:49 2001=0A=
+++ /pub/home/manfred/main.c	Sat Apr 14 15:56:26 2001=0A=
@@ -777,6 +777,13 @@=0A=
 =0A=
 	(void) dup(0);=0A=
 	(void) dup(0);=0A=
+=0A=
+	while (waitpid(-1, (unsigned int *)0, __WALL|WNOHANG) > 0)=0A=
+		;=0A=
+	spin_lock_irq(&current->sigmask_lock);=0A=
+	flush_signals(curtask);=0A=
+	recalc_sigpending(curtask);=0A=
+	spin_lock_irq(&current->sigmask_lock);=0A=
 	=0A=
 	/*=0A=
 	 * We try each of these until one succeeds.=0A=

------=_NextPart_000_0021_01C0C4FC.049C51D0--