Re: [PATCH] 2.4.4-ac11 network drivers cleaning

[Andrzej Krzysztofowicz]

> 
> On Sat, 19 May 2001 17:58:49 -0400, 
> Jeff Garzik <[e-mail]> wrote:
> >Finally, I don't know if I mentioned this earlier, but to be complete
> >and optimal, version strings should be a single variable 'version', such
> >that it can be passed directly to printk like
> >
> >	printk(version);
> 
> Nit pick.  That has random side effects if version contains any '%'
> characters.  Make it

It should not. I see no reason for a literal % in the version string.

> 
> 	printk("%s\n", version);
> 
> Not quite as optimal but safer.

It is simpler to remove the %s from version. I don't think any of them
require it. If one add a % he should know what he is doing.

-- 
=======================================================================
  Andrzej M. Krzysztofowicz               [e-mail]
  tel.  [phone]
Wydz.Fizyki Technicznej i Matematyki Stosowanej Politechniki Gdanskiej