(no subject)

[Richard Gooch]

Ph. Marek writes:
> in fs/devfs/util.c is
> 	void __init devfs_make_root (const char *name)
> which is wrong as pivot_root allows changing the root-device in the runtime.
> 
> I think it should be 
> 	void __init devfs_make_root (const char *name)
> and get called by
> fs/super.c:
> 	asmlinkage long sys_pivot_root(const char *new_root, const char *put_old)
> after
> 	chroot_fs_refs(root,root_mnt,new_nd.dentry,new_nd.mnt);
> 	error = 0;
> 
> Is that correct?

No, because devfs_mk_root() only ever needs to called from
mount_root(). If you're doing pivot_root() then you've got initrd, in
which case you can create compatibility symlinks from user-space.

				Regards,

					Richard....
Permanent: [e-mail]
Current:   [e-mail]