Re: PATCH: maestro ported to 2.4 PCI API

[Francois Romieu]

Marcus Meissner <[e-mail]> ecrit :
[...]
>  	if( request_region(iobase, 256, card_names[card_type]) == NULL )
>  	{
>  		printk(KERN_WARNING "maestro: can't allocate 256 bytes I/O at 0x%4.4x\n", iobase);
> -		return 0;
> -	}
> -
> -	/* this was tripping up some machines */
> -	if(pcidev->irq == 0) {
> -		printk(KERN_WARNING "maestro: pci subsystem reports irq 0, this might not be correct.\n");
> +		return -EBUSY;
>  	}
>  
>  	/* just to be sure */
> @@ -3406,7 +3429,7 @@
>  	if(card == NULL)
>  	{
>  		printk(KERN_WARNING "maestro: out of memory\n");
> -		return 0;
> +		return -ENOMEM;

request_region is unbalanced in this return path.

-- 
Ueimor