Re: [CHECKER] 84 bugs in 2.4.4/2.4.4-ac8 where NULL pointers are

Alexander Viro (viro@math.psu.edu)
Wed, 30 May 2001 02:58:10 -0400 (EDT)


On Wed, 30 May 2001, Andreas Dilger wrote:

> > b) doesn't fix anything that could be triggered - ext2_delete_entry()
> > can happen only if you've already done lookup. I.e. no problems had been
> > found in that block back when we were finding the entry.
>
> That means there is no need to check dir in ext2_check_dir_entry(),
> is there? If all callers to ext2_delete_entry() already verify the
> buffer in ext2_find_entry() (which they appear to do), then there is
> no point in calling ext2_check_dir_entry() at all.

<shrug> modulo memory corruption right under you - yes.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/