Re: [ PATCH ]: disable pcspeaker kernel: 2.4.2 - 2.4.5

[Nico Schottelius]

> > less code / one int more in the kernel
> > or
> > more code and #ifs / one int less in the kernel
>
> if the #ifdefs bloat the code 4 times the size of the simple patch, then
> we obviously want 4 bytes more in the kernel.

Okay.

> > And what about the code from kernel/sys.c ? The version you provided
> > doesn't take care of what's the default value of pcspeaker. This would
> > make it undefined, which is not really good.
>
> the default value is 0, that is good enough.

hmm.. I don't think so... value of 1 would be much better, because
0 normally disables the speaker.
So setting somewhere pcspeaker_enabled = 1 should be better
than having it with 0.

So in kernel/sysctl.c:

int pcspeaker_enabled = 1;

or anybody against this ?

Nico