Re: 2.4.5 -ac series broken on Sparc64

Russell King (rmk@arm.linux.org.uk)
Thu, 31 May 2001 10:21:13 +0100


On Wed, May 30, 2001 at 08:58:19AM +0100, Alan Cox wrote:
> > include/linux/irq.h:61: asm/hw_irq.h: No such file or directory
> > *** [sched.o] Error 1
>
> The sparc64 tree isnt very well integrated with -ac. What I have I merge but
> where -ac varies from the Linus tree or the Linus tree requires new files
> tends to break it.
>
> It can probably be an empty file

I've had reports of this on the ARM tree. I've always taken the view that
if a driver is including linux/irq.h, then it is buggy. It has no business
including that file - it only contains structures and definitions relating
to architecture specific code.

In Linus' tree, the only reference outside arch code to linux/irq.h is:

drivers/pcmcia/hd64465_ss.c:#include <linux/irq.h>

and it'd be good to get rid of that one as well, but AFAICS this is a
sh specific driver.

Please, lets not make it compulsary for architectures to implement the irq
handling described in linux/irq.h.

--
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/