Re: [PATCH] for Linux IRDA initialisation bug 2.4.5

Keith Owens (kaos@ocs.com.au)
Fri, 01 Jun 2001 23:59:13 +1000


On Fri, 1 Jun 2001 23:32:46 +1000,
Matt Chapman <matthewc@cse.unsw.edu.au> wrote:
>I've found that if you compile IRDA into the kernel, irda_proto_init
>gets called twice - once at do_initcalls time, and once explicitly
>in do_basic_setup - eventually resulting in a hang (as
>register_netdevice_notifier gets called twice with the same struct,
>and it's list becomes circular).

The suggested patch has one non-obvious side effect which somebody in
irda needs to verify is OK. Previously irda_proto_init() and
irda_device_init() were called after every other driver had
initialized. Now irda_proto_init() is called based on the object order
in the top level Makefile, so irda is initialized before i2c,
telephony, acpi and mddev. Is this a valid initialization order? If
not, move

DRIVERS-$(CONFIG_IRDA) += drivers/net/irda/irda.o

to the end of the drivers list and document why it needs to be there.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/