Re: Minor "cleanup" patches for 2.4.5-ac kernels

Michal Jaegermann (michal@harddata.com)
Thu, 14 Jun 2001 12:30:16 -0600


On Thu, Jun 14, 2001 at 07:05:55PM +0100, Alan Cox wrote:
> > --- linux-2.4.5ac/drivers/pci/quirks.c~ Tue Jun 12 16:31:12 2001
> > +++ linux-2.4.5ac/drivers/pci/quirks.c Tue Jun 12 17:13:18 2001
> > @@ -18,6 +18,7 @@
> > #include <linux/pci.h>
> > #include <linux/init.h>
> > #include <linux/delay.h>
> > +#include <linux/sched.h>
>
> Ok

Jeff Garzik had some comments here and other, architecture dependent,
propositions.

> >
> > This one is replacing a symbol in sg.c to one which is exported
> > so 'sg.o' can be compiled as a valid module.
>
> Export the right symbol on Alpha ?

I do not see how this one is Alpha specific. Patches from 'ac' series
added one reference to 'simple_strtol' in drivers/scsi/sg.c. Sure, one
more symbol can be exported, but results of this call are used only as a
zero/non-zero flag so an already exported 'simple_strtoul' will serve
instead (or we have an extra export for _one_ call in the whole kernel).

Michal
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/