Re: [PATCH] skb destructor enhancement idea

David S. Miller (davem@redhat.com)
Mon, 25 Jun 2001 16:12:25 -0700 (PDT)


Will writes:
> > Add an ifdef and the knobs you need to the skb struct directly just
> > like netfilter does.
>
> So I should #ifdef throughout the tcp and socket code wherever skb's 'destructor' is
> called to call mine as well? And multiply that by N driver writers who'd like to do
> the same thing? Sounds messy...

Besides low-level packet frobbing, I can't think of any other
application.

In fact, more appropriate would be to extend netfilter to handle
low-level things as well as med/upper level things.

Then we wouldn't need driver specific things, this is my whole
point. You're designing for yourself and nobody else. When
people want to add things to sk_buff it usually is for a
not so well thought reason.

Later,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/