Re: New FarSync T-Series driver

François romieu (romieu@zoreil.com)
Wed, 4 Jul 2001 16:18:45 +0200

The Tue, Jul 03, 2001 at 06:28:03PM +0100, Robert J.Dunlop wrote :
[...]
> Sorry for the big post, but I posted URLs for an earlier version of this
> a couple of months back and got very little feedback. I know sync card
> drivers ain't sexy.

Just my HO:
* error_1, error_2... error_n labels are ugly;
* ioremap may fail;
* mix of spin_lock and FST_LOCK isn't nice (kill the latter ?);
*
+ offset = BUF_OFFSET ( rxBuffer[pi][i]);
[...]
+ card->mem + BUF_OFFSET ( rxBuffer[pi][rxp][0]),

A bit of a macro abuse imho.

*
+ if ( ++port->txpos >= NUM_TX_BUFFER )
+ port->txpos = 0;

Why not:
port->txpos++;
foo = port->txpos%NUM_TX_BUFFER;

--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/