Re: [PATCH] copy_from_high_bh
Mark Hemment (email@example.com)
Sun, 8 Jul 2001 19:26:01 +0100 (BST)
On Sun, 8 Jul 2001, Linus Torvalds wrote:
> On Sun, 8 Jul 2001 firstname.lastname@example.org wrote:
> > mm/highmem.c/copy_from_high_bh() blocks interrupts while copying "down"
> > to a bounce buffer, for writing.
> > This function is only ever called from create_bounce() (which cannot
> > be called from an interrupt context - it may block), and the kmap
> > 'KM_BOUNCE_WRITE' is only used in copy_from_high_bh().
> If so it's not just the interrupt disable that is unnecessary, the
> "kmap_atomic()" should also be just a plain "kmap()", I think.
That might eat through kmap()'s virtual window too quickly.
I did think about adding a test to see if the page was already mapped,
and falling back to kmap_atomic() if it isn't. That should give the best
of both worlds?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to email@example.com
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/