Re: Inclusion of zoned inactive/free shortage patch

[Linus Torvalds]

On Tue, 17 Jul 2001, Marcelo Tosatti wrote:
>
> > A single-zone parameter just looks fundamentally broken.
>
> The "zone" parameter passed to swap_out() means "don't unmap pte's mapping
> to pages belonging to not-under-shortage zones". It can (and it should) be
> replaced by a "zone_specific" parameter.

Ahh.

In fact, it should be replaced by a single bit.

Passing in a "zone *" and then using it purely as a boolean makes no
sense.

But that still makes me ask: why do you have that (misnamed, and
mis-typed) boolean there in the first place? Why not just unconditionally
have the "zone_shortage(page->zone)"?

		Linus