Re: [PATCH] make riscom8.c build (248p4)

Keith Owens (kaos@ocs.com.au)
Mon, 06 Aug 2001 05:24:22 +1000


On Sun, 5 Aug 2001 18:22:08 +0200,
Rasmus Andersen <rasmus@jaquet.dk> wrote:
>--- linux-248-pre4-clean/drivers/char/riscom8.c Sun Aug 5 14:34:54 2001
>+++ linux-248p4-kbuild/drivers/char/riscom8.c Sun Aug 5 18:14:29 2001
>@@ -1866,10 +1866,10 @@
> __setup("riscom8=", riscom8_setup);
> #endif
>
>-static const char banner[] __initdata =
>+static char banner[] __initdata =
> KERN_INFO "rc: SDL RISCom/8 card driver v1.1, (c) D.Gorodchanin "
> "1994-1996.\n";
>-static const char no_boards_msg[] __initdata =
>+static char no_boards_msg[] __initdata =
> KERN_INFO "rc: No RISCom/8 boards detected.\n";
>

It is even documented in Documentation/DocBook/kernel-hacking.tmpl that
__initdata cannot be const. Not all versions of gcc flag an error,
newer ones do.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/