Re: [PATCH] one of $BIGNUM devfs races

Alexander Viro (viro@math.psu.edu)
Tue, 7 Aug 2001 02:40:30 -0400 (EDT)


On Tue, 7 Aug 2001, Richard Gooch wrote:

> > Notice that here you have pointer to 'entry', so there is no problem
> > with passing it. ->read_inode() simply goes away. Besides, that way
> > you don't pollute icache hash chains - devfs inodes stay out of hash.
>
> Um, what will happen to inode change events? What exactly is the
> purpose of these hash chains?

iget() uses them to find inode by superblock and inode number.
If you don't use iget()...

I'm not sure what do you call an inode change event, though. Stuff
like chmod() and friends? They call ->setattr() (devfs_notify_change(),
in your case) and that has nothing to icache (you already have the
inode). Or had I completely misparsed you?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/