Re: [PATCH] one of $BIGNUM devfs races

[Richard Gooch]

Alexander Viro writes:
> 
> 
> On Tue, 7 Aug 2001, Richard Gooch wrote:
> 
> > > Notice that here you have pointer to 'entry', so there is no problem
> > > with passing it. ->read_inode() simply goes away. Besides, that way
> > > you don't pollute icache hash chains - devfs inodes stay out of hash.
> > 
> > Um, what will happen to inode change events? What exactly is the
> > purpose of these hash chains?
> 
> iget() uses them to find inode by superblock and inode number.
> If you don't use iget()...

OK.

> I'm not sure what do you call an inode change event, though. Stuff
> like chmod() and friends?

Yes, that's what I meant.

> They call ->setattr() (devfs_notify_change(), in your case) and that
> has nothing to icache (you already have the inode). Or had I
> completely misparsed you?

You parsed correctly. I know ->setattr() is called. I just wanted to
make sure that the icache didn't have some subtle interaction I was
missing. Such as ->write_inode() not being called.

				Regards,

					Richard....
Permanent: [e-mail]
Current:   [e-mail]