Re: [patch] dz.c 64 bit locking issues

[Jes Sorensen]

>>>>> "Maciej" == Maciej W Rozycki <[e-mail]> writes:

Maciej> On Fri, 17 Aug 2001, Ralf Baechle wrote:
>> > The dz.c driver has an instance where it does save_flags() to a 32
>> bit > type which isn't safe for 64 bit boxen.
>> 
>> It's safe because a MIPS only driver.

Maciej>  Not necessarily.  It might be safe now, but there is a
Maciej> TURBOchannel serial card with DZ11-compatible chipset that could
Maciej> be driven by the dz.c code after a few tweaks.  And chances are
Maciej> someone will finish writing support for TURBOchannel Alphas one
Maciej> day...

Maciej>  The change is harmless anyway.

Yep, I also think it's better for cosmetic reasons that we make all
drivers use unsigned long. That way the chance of someone else copying
bad code for a new driver is less likely.

Jes