RE: /dev/random entropy calcs - patch [not related to net devices]

David Schwartz (davids@webmaster.com)
Tue, 21 Aug 2001 15:54:50 -0700

> + time = (__u32)(xtime.tv_usec) ^ (__u32)(xtime.tv_sec);

I would prefer:

time = (__u32)xtime.tv_usec | ( (__u32)(xtime.tv_sec)<<20) );

The way you have it, you collide the two least-significant bits,
potentially losing some entropy.

DS

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/