Re: brlock_is_locked()?

[Ben LaHaise]

On Wed, 22 Aug 2001, Brad Chapman wrote:

> restart:
> 	if (brlock_is_locked(BR_NETPROTO_LOCK)) {
> 		CRITICAL_SECTION
> 		br_write_unlock_bh(BR_NETPROTO_LOCK);
> 	}
> 	else {
> 		/* Let's get dizzy */
> 		br_write_lock_bh(BR_NETPROTO_LOCK);
> 		goto restart;
> 	}

That code can never work.  None of the linux spinlocks track ownership, so
checking if a lock is locked tells you if your process or another has
ownership of the lock.  The above pseudo code is going to result in lots
of mangled data.

		-ben