Re: PROBLEM: usb not working with 2.4.8-ac8

[Johannes Erdfelt]

On Fri, Aug 24, 2001, Pete Zaitcev <[e-mail]> wrote:
> > What was you test scenario where you didn't see a completion callback?
> 
> The root hub emulation never posts one.

Hmm, it should. I'll check that again.

> > > +	if (ret == 0) {				/* N.B. Done, must notify */
> > > +		/* uhci_call_completion(urb); */ /* ->> uhci_destroy_urb_priv */
> > > +		urb->dev = NULL;
> > > +		if (urb->complete)
> > > +			urb->complete(urb);
> > > +	}
> > >  
> > > -	usb_dec_dev_use(urb->dev);
> > > +	usb_dec_dev_use(dev);
> 
> > What's all of this for? Protecting against an urb->dev race condition?
> 
> No race, but we cannot use urb after callback.

Ahh, good point.

Thanks.

JE