Re: [PATCH] Oops in usb-storage.c

Jan Niehusmann (jan@gondor.com)
Wed, 17 Oct 2001 03:44:10 +0200


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue, Oct 16, 2001 at 06:32:43PM -0700, Matthew Dharm wrote:
> No, I think something different is best.
>
> Your first change to push the US_FL_FIX_INQUIRY code down after the test
> for pusb_dev is good.. but, in the case where that pointer is bad, we need
> to cook up something totally fake, like INQUIRY data that says
> "DISCONNECTED" "USB-STORAGE DEVICE" or somesuch.....

Then I don't understand why we have to answer the INQUIRY at all.
This could as well be a disconnected / turned off external scsi
device. I often turn off my external scsi scanner while the system
is running, without a problem up to now. The scanner surely doesn't
answer to INQUIRYs when it's turned off...

By the way - a device not needing the US_FL_FIX_INQUIRY code wouldn't
answer to INQUIRYs either, when it's disconnected. So the patch I sent
first gives the same behaviour for devices with and without
US_FL_FIX_INQUIRY set.

Jan

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE7zOJqnIUccvEtoGURAsf2AKCeLHIRZQ0OZvDkfOYVeihO+Q1izwCfV2NH
kmYJCxqlFALOaUPjZcomjy4=
=T2Uu
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/