Re: [sparc] Weird ioctl() bug in 2.2.19 (fwd)

Alex Buell (alex.buell@tahallah.demon.co.uk)
Wed, 31 Oct 2001 20:00:22 +0000 (GMT)


On Wed, 31 Oct 2001, David S. Miller wrote:

> I'm pretty sure the ioctl numbers are wrong, and that is what is
> causing the problem.

No, the ioctl numbers are correct, it's ESD that's fscked.

/* set the sound driver audio format for playback */
#if defined(__powerpc__)
value = test = ( (esd_audio_format & ESD_MASK_BITS) == ESD_BITS16 )
? /* 16 bit */ AFMT_S16_NE : /* 8 bit */ AFMT_U8;
#else /* #if !defined(__powerpc__) */
value = test = ( (esd_audio_format & ESD_MASK_BITS) == ESD_BITS16 )
? /* 16 bit */ AFMT_S16_LE : /* 8 bit */ AFMT_U8;
#endif /* #if !defined(__powerpc__) */

<sarcasm>
This is such a lovely piece of code!
<sarcasm>

Anyway, I can fix it now by adding the appropriate AFMT_S16_BE statement
guarded by a #ifdef but this sucks. Thanks to Peter Jones who spotted this
one.

-- 
Come the revolution, humourless gits'll be first up against the wall.

http://www.tahallah.demon.co.uk

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/