Re: bdevname(), cdevname(), kdevname() - static buffers

Alan Cox (alan@lxorguk.ukuu.org.uk)
Fri, 2 Nov 2001 18:59:21 +0000 (GMT)


> I was looking at the usage of bdevname(), cdevname(), and kdevname(),
> and noticed that they each return a pointer to a static buffer.
> This buffer contains a formatted device name, which is typically
> printed immediately following the call. However, I don't see any
> explicit lock protection for these buffers.
>
> For SMP systems, is there something implicit in their use that
> prevents a race on these buffers? Has anyone seen garbled device
> names being printed (which might be attributed to a race)?

Not currently, other than statistics being on our side. It probably should
be touched up in 2.4 to use per cpu buffers and perhaps 2.5 pass a buffer
in
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/