Re: [PATCH] v2.5.1-pre9-00_kvec.diff

Benjamin LaHaise (bcrl@redhat.com)
Tue, 11 Dec 2001 22:37:11 -0500


On Tue, Dec 11, 2001 at 09:35:15PM -0600, Steven Walter wrote:
> > + nr_pages = (ptr + len + PAGE_SIZE - 1) >> PAGE_SHIFT;
> > + nr_pages -= ptr >> PAGE_SHIFT;
>
> Isn't this the same as
> nr_pages = (len + PAGE_SIZE -1) >> PAGE_SHIFT;

No.

> ? Or am I missing something?

Yes. Pointers may not be page aligned.

-ben

-- 
Fish.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/