Re: [RFC] [PATCH] Clean up fs.h union for ext2

[Legacy Fishtank]

On Thu, Dec 27, 2001 at 04:21:42AM +0100, Daniel Phillips wrote:
> --- ../2.4.17.clean/include/linux/fs.h	Fri Dec 21 12:42:03 2001
> +++ ./include/linux/fs.h	Wed Dec 26 23:30:55 2001
> @@ -478,7 +478,7 @@
>  	__u32			i_generation;
>  	union {
>  		struct minix_inode_info		minix_i;
> -		struct ext2_inode_info		ext2_i;
> +		struct ext2_inode_info		ext2_inode_info;
>  		struct ext3_inode_info		ext3_i;
>  		struct hpfs_inode_info		hpfs_i;
>  		struct ntfs_inode_info		ntfs_i;

Change in principle looks good except IMHO you should go ahead and
remove the ext2 stuff from the union...  (with the additional changes
that implies)

	Jeff