Mapped pages handling in shrink_cache()

alad@hss.hns.com
Sat, 29 Dec 2001 15:47:48 +0530


Hi, In the following code from shrink_cache()

if (PageDirty(page) && is_page_cache_freeable(page) && page->mapping)
{
.
.
.

int (*writepage)(struct page *);

writepage = page->mapping->a_ops->writepage;
if ((gfp_mask & __GFP_FS) && writepage) {
ClearPageDirty(page);
SetPageLaunder(page);
page_cache_get(page);
spin_unlock(&pagemap_lru_lock);

writepage(page);
page_cache_release(page);

spin_lock(&pagemap_lru_lock);
continue; <<<<<<< shouldn't the page be unlocked before
continuing with the next page <<<<<
}

I am reading 2.4.16

-- Amol

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/