Re: PATCH 2.5.2.6: fix up serial, sysrq

Andries.Brouwer@cwi.nl
Thu, 3 Jan 2002 02:36:26 GMT


From: Jeff Garzik <jgarzik@mandrakesoft.com>

The kdev_none change might not be correct, please check.

Indeed, I would say it is not.

- if (!is_local_disk(sb->s_dev) && MAJOR(sb->s_dev))
+ if (!is_local_disk(sb->s_dev) && !kdev_none(sb->s_dev))
go_sync(sb, remount_flag);

Without studying the surrounding code, I conjecture that
the test MAJOR(sb->s_dev) was meant to exclude anonymous
devices (with major 0), not only NODEV.

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/