Re: MINOR(inode->i_rdev) vs. minor(inode->i_rdev)

Nikita Gergel (fc@yauza.ru)
Wed, 9 Jan 2002 22:55:17 +0300


--=.jmsM,88Of)Y?_Y
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On 09 Jan 2002 14:20:23 -0500
Brendan Burns <bburns@eksl.cs.umass.edu> wrote:

> Hello,
Hello!

> In the process of compiling ALSA for my new 2.5.2pre10 kernel I noticed
> that MINOR(inode->i_rdev) causes compile errors and should be replaced
> with minor(inode->i_rdev) Looking at a number of the OSS sound drivers
> in the kernel I noticed that they to would not compile in 2.5.2pre10 (eg
> Turtle Beach Pinnacle) I fixed all of these modules and a patch is
> attached. However, looking further I noticed that there were similar
> problems in a number of other drivers. Before I undertook cleaning all
> of them I thought I would check in and make sure I was doing the right
> thing. Namely that every instance of MINOR(inode->i_rdev) or
> MINOR(i_rdev) should be replaced with minor(inode->i_rdev) or
> minor(i_rdev).

I've contributed patch for emu10k1, because tests after 'MINOR' replacement successed. You're on the right way.

Regards.

-- 
Nikita Gergel					System Administrator
Moscow, Russia					YAUZA-Telecom

--=.jmsM,88Of)Y?_Y Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux)

iD8DBQE8PKAnFP8BYTTFfXkRAowLAKCs9cOXROjKRpyD3Q0hN26y5wgFpwCfYDlk SBfaUEyQnG8RZ2vlbAlqzwY= =/xEn -----END PGP SIGNATURE-----

--=.jmsM,88Of)Y?_Y--

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/