Re: [PATCH] __linux__ and cross-compile

[Momchil Velikov]

>>>>> "Adrian" == Adrian Bunk <[e-mail]> writes:
Adrian> If your compiler is configured as a cross-compiler everything should work
Adrian> as expected. If you are trying to compile a Linux kernel with a gcc that
Adrian> is configured to build binaries for NetBSD this sounds evil.

Could you elaborate why ? I think people do it all the time, compiling
linux (which is not a _linux_ binary, but a i386, alpha, etc. binary)
with a compiler configured to compile linux binaries.

>> >> __KERNEL_ as an indication that the source is compiled as a part of
>> >> ...
>> 
Adrian> This is definitely wrong in files that are not Linux-specific and that are
Adrian> used on FreeBSD (and BSDI) as well (you would know that if you'd looked at
Adrian> the files your patch changes)...
>> 
>> *BSD define _KERNEL, don't they ?

Adrian> I don't know (I never tried to compile a *BSD kernel).
Adrian> But if yes please consider what the following parts of your patch change:

Adrian> -#ifndef __linux__
Adrian> +#ifndef __KERNEL__

I have. Have you ?

Regards,
-velco