[PATCH] free_swap_and_cache misses

Hugh Dickins (hugh@veritas.com)
Mon, 21 Jan 2002 00:21:29 +0000 (GMT)


free_swap_and_cache() often misses its purpose and leaves freeable page
in swap and cache. Wrong in mainline 2.4 and 2.5, but looks okay in -aa
(so don't bother to apply this if you're now merging that).

Hugh

--- 2.4.18-pre4/mm/swapfile.c Sun Dec 23 10:47:32 2001
+++ linux/mm/swapfile.c Sun Jan 20 23:30:52 2002
@@ -344,7 +344,7 @@
if (page) {
page_cache_get(page);
/* Only cache user (+us), or swap space full? Free it! */
- if (page_count(page) == 2 || vm_swap_full()) {
+ if (page_count(page) - !!page->buffers == 2 || vm_swap_full()) {
delete_from_swap_cache(page);
SetPageDirty(page);
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/