Re: [Patch - 2.4.17++] Fix undefined ksym in minix.o, ext2.o, sysv.o

David Woodhouse (dwmw2@infradead.org)
Tue, 22 Jan 2002 23:58:53 +0000

ktk@bigfoot.com said:
> Fair enough. A "grep -r" showed it existing only in ./fs/ and only
> ref'd by ext2, sysv and minix; so I figured a conditional wrap-around
> wouldn't hurt. But I didn't stop to consider 3rd party modules...

It's not just third-party modules. Even the modules in the tree get bitten
by such brokenness - consider what happens if you compile your kernel
without support for the filesystem in question but later need to compile
the module. With the #ifdef there, you'd need to recompile (and reboot) the
whole thing.

Anything in the kernel image which is dependent on CONFIG_*_MODULE is, as a
general rule, broken. Sometimes there are justifications for it. Not often,
though.

--
dwmw2




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/