[PATCH] add BUG_ON to 2.4 #2

David Garfield (garfield@irving.iisd.sra.com)
Fri, 25 Jan 2002 18:25:07 -0500


Robert Love writes:
...
> diff -urN linux-2.4.18-pre7/mm/vmscan.c linux/mm/vmscan.c
> --- linux-2.4.18-pre7/mm/vmscan.c Thu Jan 24 13:48:18 2002
> +++ linux/mm/vmscan.c Fri Jan 25 18:05:14 2002
...
> @@ -354,10 +354,8 @@
>
> page = list_entry(entry, struct page, lru);
>
> - if (unlikely(!PageLRU(page)))
> - BUG();
> - if (unlikely(PageActive(page)))
> - BUG();
> + BUG_ON(unlikely(!PageLRU(page)));
> + BUG_ON(unlikely(PageActive(page)))
>
> list_del(entry);
> list_add(entry, &inactive_list);
>

While I don't know the exact definitions, this works out to:

if (unlikely(unlikely(!PageLRU(page)))) BUG();

which I doubt is a good idea.

--David Garfield
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/