Re: [PATCH]: Fix MTRR handling on HT CPUs (improved)

[Martin Wilck]

> > So why not just set it twice - surely that is harmless ? Why add complex
> > code ?
>
> At the _least_ you have to serialize the thing, which is most of what the
> patch actually does.

I suppose you're talking about the Intel patch, not mine, which is
obviously out. I admit it was too complex.

The problem with the original code is that it combines reading the status
of the MTRR default register and disabling cache in a single step that
is performed simultaneously by all CPUs.
The patch from Intel inserts synchronization between these two steps,
thereby avoiding that the second CPU reads a "defaults status" that in
reality is the "cache disabled" status the first CPU had set before.
This suffices to fix the problem.

Martin

-- 
Martin Wilck                Phone: [phone]
Fujitsu Siemens Computers   Fax:   [phone]
Heinz-Nixdorf-Ring 1	    mailto:[e-mail]
D-33106 Paderborn           http://www.fujitsu-siemens.com/primergy