Re: [PATCH] 2.5: push BKL out of llseek

Linus Torvalds (torvalds@transmeta.com)
Tue, 29 Jan 2002 16:09:22 -0800 (PST)


On 29 Jan 2002, Robert Love wrote:
>
> This patch pushes the BKL out of llseek() and into the individual llseek
> methods. For generic_file_llseek, I replaced it with the inode
> semaphore.

Thinking about that, that actally sounds like the _right_ thing to do even
from a correctness standpoint - as llseek() looks at the inode size, so we
should have that lock anyway.

So I'd suggest doing the inode semaphore globally, instead of using
kernel_lock at all.

Al?

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/