Re: [PATCH] 2.5: push BKL out of llseek

[Linus Torvalds]

On 29 Jan 2002, Robert Love wrote:
>
> Another gain from pushing the locks into each method is that we can pick
> and choose as-needed.  If it turns out inode semaphore is a global
> solution, the following patch is sufficient.  Otherwise, we could
> replace the lock_kernel in each caller with the inode semaphore, as
> appropriate.  Oh Al ??

Doing it in the low-level filesystem would match how we now do it inside
generic_file_write() - ie the locking is done by the low-level filesystem,
but most low-level filesystems choose to use a generic helper function.

And I think your patch is slightly wrong:

> +	down(&file->f_dentry->d_inode->i_sem);

That should really be:

	file->f_dentry->d_inode->i_mapping->host->i_sem

to get the hosted filesystem case right (ie coda).

		Linus