Re: [PATCH] per-cpu areas for 2.5.3-pre6

Linus Torvalds (torvalds@transmeta.com)
Tue, 29 Jan 2002 18:12:37 -0800 (PST)


On Wed, 30 Jan 2002, Rusty Russell wrote:
>
> Boots and runs: more cleanups will follow once this is in...

May I suggest a few more cleanups before I apply it, namely try to
abstract out that "&__per_cpu_end-&__per_cpu_start" thing and make it more
readable what is going on in setup_per_cpu_areas() which (quite frankly)
is otherwise a prime candidate for the obfuscated C contest.

Also, wouldn't it be much nicer to just leave CPU#0 at the start of
.data.percpu, and not have to have an offset for CPU0 at all? That would
sure make the UP case cleaner.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/